Skip to content

Remove unnecessary authorize_user! filter [can be updated]

Witrem requested to merge github/fork/cirosantilli/rm-unnecessary-authorize into master

Created by: cirosantilli

from Project controllers. The filter is already implied by ApplicationController#project which is used as a before_filter.

Faster because one less helper, less redundant code.

It is implied because:

  • authorization is skipped iff user can read_project, which is checked in def project
  • other cases lead to either authorize_user! or 404 as expected
  • the project filter is not skipped in any project controller

Merge request reports

Loading